Skip to content

SK-3209 FlowVault Java parity: add query, getTokens, uploadFiles and deleteFiles - #461

Open
skyflow-himanshupal wants to merge 15 commits into
mainfrom
flowvault-release/26.10.4
Open

skyflow-himanshupal wants to merge 15 commits into
mainfrom
flowvault-release/26.10.4

Conversation

@skyflow-himanshupal

Copy link
Copy Markdown
Collaborator

Summary

Brings the FlowVault Java SDK to parity with the other FlowVault SDKs by adding the query, token-retrieval and file APIs, built on a regenerated REST client.

Changes

  • New APIs on the FlowVault VaultController:
    • query: runs a SQL query against the vault, with response metadata.
    • getTokens: gets tokens for existing records.
    • uploadFiles: uploads files to file columns.
    • deleteFiles: deletes files from records.
  • Request, response and options models for each new API (vault/data), plus validations and error/log messages.
  • Regenerated REST client (generated/rest): adds the files and tokens resources, typed HTTP errors, raw/async clients and core updates.
  • Samples: QueryExample, GetTokensExample, UploadFilesExample, DeleteFilesExample.
  • Docs: FlowVault README updated for the new APIs.
  • Tests: unit tests for the new APIs, validations, upload formats and request fidelity; fixes for failing E2E tests and review feedback (SK-3204).

skyflow-himanshupal and others added 15 commits October 7, 2026 15:10
…-Java-parity-fix

SK-3168,SK-3204-Add-query-getTokens-uploadFiles-and-deleteFiles-to-flowvault
* SK-3253:Add gated retry on 401 status code for both skyvault & flowvault SDKs.

* SK-3253:Fix failed token regeneration when concurent 401 failures.

* SK-3253:Update unit tests to cover both skyvault & flowvault.

* SK-3252:Update null check.

* [AUTOMATED] Private Release 1.2.0-dev-23391b03

* SK-3253:Update warning log & test.

* [AUTOMATED] Private Release 1.2.0-dev-20ef0615

---------

Co-authored-by: yaswanth-pula-skyflow <yaswanth-pula-skyflow@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions

Copy link
Copy Markdown

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.54%. Comparing base (3972351) to head (e6ff624).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #461      +/-   ##
============================================
+ Coverage     91.29%   91.54%   +0.24%     
- Complexity        0       60      +60     
============================================
  Files           174      195      +21     
  Lines          7401     7613     +212     
  Branches       1024     1024              
============================================
+ Hits           6757     6969     +212     
  Misses          422      422              
  Partials        222      222              
Flag Coverage Δ
unittests-flowvault 91.38% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Module: common 91.28% <100.00%> (+0.45%) ⬆️
Module: skyvault 94.98% <ø> (ø)
Module: flowvault 88.45% <ø> (+0.52%) ⬆️
Service Account 87.76% <ø> (ø)
Vault Data 92.05% <100.00%> (+1.24%) ⬆️
Vault Tokens 99.03% <ø> (ø)
Vault Connection 100.00% <ø> (ø)
Vault Controller 82.75% <ø> (ø)
Detect 100.00% <ø> (ø)
Audit 100.00% <ø> (ø)
BIN Lookup 100.00% <ø> (ø)
Config 96.26% <ø> (ø)
Utils 90.53% <ø> (ø)
Errors 100.00% <ø> (ø)
Enums 100.00% <ø> (ø)
Logs 100.00% <100.00%> (ø)
Files with missing lines Coverage Δ
...src/main/java/com/skyflow/errors/ErrorMessage.java 100.00% <ø> (ø)
...mmon/src/main/java/com/skyflow/logs/ErrorLogs.java 100.00% <100.00%> (ø)
...ommon/src/main/java/com/skyflow/logs/InfoLogs.java 100.00% <100.00%> (ø)
...com/skyflow/vault/data/BaseDeleteFilesRequest.java 100.00% <100.00%> (ø)
...om/skyflow/vault/data/BaseDeleteFilesResponse.java 100.00% <100.00%> (ø)
...a/com/skyflow/vault/data/BaseGetTokensRequest.java 100.00% <100.00%> (ø)
.../com/skyflow/vault/data/BaseGetTokensResponse.java 100.00% <100.00%> (ø)
...com/skyflow/vault/data/BaseUploadFilesRequest.java 100.00% <100.00%> (ø)
...om/skyflow/vault/data/BaseUploadFilesResponse.java 100.00% <100.00%> (ø)
...owvault/src/main/java/com/skyflow/VaultClient.java 97.22% <ø> (-0.04%) ⬇️
... and 20 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3972351...e6ff624. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@promptless

promptless Bot commented Nov 10, 2026

Copy link
Copy Markdown

Promptless documentation updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants